Skip to content

chore: move workspace apps tests to new package #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023
Merged

chore: move workspace apps tests to new package #7025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6829588
chore: move workspace apps tests to new package
deansheather Apr 6, 2023
c24095b
chore: move reconnecting pty to apptest package
deansheather Apr 6, 2023
40daa36
Rename apptest Run
Emyrk Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename apptest Run
  • Loading branch information
@Emyrk
Emyrk committed Apr 6, 2023
commit 40daa3690f3a153d006c3bf537e84f55e10bb0f6
4 changes: 2 additions & 2 deletions coderd/workspaceapps/apptest/apptest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ import (
"github.com/coder/coder/testutil"
)

// RunTests runs the entire workspace app test suite against deployments minted
// Run runs the entire workspace app test suite against deployments minted
// by the provided factory.
func RunTests(t *testing.T, factory DeploymentFactory) {
func Run(t *testing.T, factory DeploymentFactory) {
setupProxyTest := func(t *testing.T, opts *DeploymentOptions) *AppDetails {
return setupProxyTestWithFactory(t, factory, opts)
}
Expand Down
2 changes: 1 addition & 1 deletion coderd/workspaceapps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func TestGetAppHost(t *testing.T) {
func TestWorkspaceApps(t *testing.T) {
t.Parallel()

apptest.RunTests(t, func(t *testing.T, opts *apptest.DeploymentOptions) *apptest.Deployment {
apptest.Run(t, func(t *testing.T, opts *apptest.DeploymentOptions) *apptest.Deployment {
deploymentValues := coderdtest.DeploymentValues(t)
deploymentValues.DisablePathApps = clibase.Bool(opts.DisablePathApps)
deploymentValues.Dangerous.AllowPathAppSharing = clibase.Bool(opts.DangerousAllowPathAppSharing)
Expand Down