fix: Parse CODER_GITAUTH_N_NO_REFRESH env var value instead of key
#7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Apr 7, 2023
kylecarbs
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in Coder v0.21.3 that setting the
CODER_GITAUTH_N_NO_REFRESHenvironment variable in our server's/etc/coder.d/coder.envconfiguration file to prevent Coder from automatically refreshing gitauth tokens caused the Coder server to fail to launch with the error:This PR updates an existing test to capture the affected code path and then fixes the issue by changing the parsing code to parse the environment variable's value instead of the environment variable's name/key.