Skip to content

chore: Refactor common server cli components for reusability #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

chore: Refactor common server cli components for reusability #7103

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66c1b13
chore: Refactor common server cli components for reusability
Emyrk Apr 12, 2023
fe70221
Import order
Emyrk Apr 12, 2023
bd9d9a0
make fmt
Emyrk Apr 12, 2023
b6286bc
Remove defer close
Emyrk Apr 12, 2023
f12bc59
Fix prometheus register
Emyrk Apr 12, 2023
7f8acbd
Close idle connections of the new http client
Emyrk Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove defer close
  • Loading branch information
@Emyrk
Emyrk committed Apr 12, 2023
commit b6286bc59ede8ecbca451cbeafd2cbc76b69130e
1 change: 0 additions & 1 deletion cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,7 +1986,6 @@ func configureHTTPServers(inv *clibase.Invocation, cfg *codersdk.DeploymentValue
if err != nil {
return nil, err
}
defer httpsListenerInner.Close()

httpServers.TLSConfig = tlsConfig
httpServers.TLSListener = tls.NewListener(httpsListenerInner, tlsConfig)
Expand Down