Skip to content

chore: Refactor common server cli components for reusability #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

chore: Refactor common server cli components for reusability #7103

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66c1b13
chore: Refactor common server cli components for reusability
Emyrk Apr 12, 2023
fe70221
Import order
Emyrk Apr 12, 2023
bd9d9a0
make fmt
Emyrk Apr 12, 2023
b6286bc
Remove defer close
Emyrk Apr 12, 2023
f12bc59
Fix prometheus register
Emyrk Apr 12, 2023
7f8acbd
Close idle connections of the new http client
Emyrk Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Import order
  • Loading branch information
@Emyrk
Emyrk committed Apr 12, 2023
commit fe70221b8a89058dfdc10fee2da673a64e80d97f
9 changes: 4 additions & 5 deletions cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,14 @@ import (
"sync/atomic"
"time"

"github.com/prometheus/client_golang/prometheus/collectors"
"github.com/prometheus/client_golang/prometheus/promhttp"

"github.com/coreos/go-oidc/v3/oidc"
"github.com/coreos/go-systemd/daemon"
embeddedpostgres "github.com/fergusstrange/embedded-postgres"
"github.com/google/go-github/v43/github"
"github.com/google/uuid"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/collectors"
"github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/spf13/afero"
"go.opentelemetry.io/otel/trace"
"golang.org/x/mod/semver"
Expand Down Expand Up @@ -236,8 +235,8 @@ func (r *RootCmd) Server(newAPI func(context.Context, *coderd.Options) (*coderd.
}()
}

//If the access URL is empty, we attempt to run a reverse-proxy
//tunnel to make the initial setup really simple.
// If the access URL is empty, we attempt to run a reverse-proxy
// tunnel to make the initial setup really simple.
var (
tunnel *tunnelsdk.Tunnel
tunnelDone <-chan struct{} = make(chan struct{}, 1)
Expand Down