Skip to content

feat(site): Ask for missing template variables in the template editor #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 17, 2023
Merged

feat(site): Ask for missing template variables in the template editor #7108

merged 8 commits into from
Apr 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma requested review from mtojek and a team April 12, 2023 19:07
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 12, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team April 12, 2023 19:07
mtojek
mtojek previously requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few things that must be improved:

  1. We need a way to let template author change values while playing with the Editor.
  2. bug: null values sent to the backend side.
  3. bug: autocomplete is unnecessary.
  4. No test cases in the PR.

@BrunoQuaresma BrunoQuaresma requested a review from mtojek April 14, 2023 16:28
mtojek
mtojek reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these comments addressed:

  1. We need a way to let template author change values while playing with the Editor.
  1. No test cases in the PR.

If we don't intend to work on these, could you open an issue to address them later?

@BrunoQuaresma
Copy link
Collaborator Author

@mtojek #7153

@BrunoQuaresma BrunoQuaresma requested a review from mtojek April 17, 2023 11:20
@BrunoQuaresma BrunoQuaresma dismissed mtojek’s stale review April 17, 2023 11:21

Waiting for a new review.

@BrunoQuaresma BrunoQuaresma merged commit d639e6b into main Apr 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/prompt-template-variables branch April 17, 2023 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rodrimaia rodrimaia rodrimaia approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

site: add support for variables to Template Editor
3 participants
@BrunoQuaresma @rodrimaia @mtojek