feat(UI): add workspace restart button #7137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to w-restart-btn/kira-pilot
Kira-Pilot
commented
Apr 14, 2023
| @@ -124,6 +124,7 @@ export const WorkspaceReadyPage = ({ | |||
| workspace={workspace} | |||
| handleStart={() => workspaceSend({ type: "START" })} | |||
| handleStop={() => workspaceSend({ type: "STOP" })} | |||
| handleRestart={() => workspaceSend({ type: "START" })} | |||
There was a problem hiding this comment.
A restart is essentially just a start, so I simplified here instead of building out a new state in our workspace machine.
There might be edge cases that require a stop before a start, but we do the exact same thing (start without stopping first) for update and we haven't had any complaints about that feature, so I figure we start simple.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #7070 and resolves #6241 (but not #5800). We've decided to implement the restart functionality entirely on the FE after realizing the previous PR would require Provisioner changes, and this small feature does not warrant such a change at this point in time.
