chore: Update pion/udp and improve parallel/non-parallel tests #7164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After re-enabling port-forward tests, I noticed we've at some point ditched our fork of So I updated the package to the next version (last one before their v2 work). See: https://github.com/coder/coder/actions/runs/4723449296/jobs/8379423014?pr=7164 |
284114b to
67caa6a
Compare
mafredri
commented
Apr 17, 2023
| @@ -21,10 +21,8 @@ import ( | |||
| "github.com/coder/coder/testutil" | |||
| ) | |||
|
|
|||
| //nolint:tparallel,paralleltest // Subtests require setup that must not be done in parallel. | |||
There was a problem hiding this comment.
I'm hoping removing parallel from the parent will allow these to run more stable, so for now let's re-enable these tests.
mafredri
commented
Apr 17, 2023
| err = <-errC | ||
| require.ErrorIs(t, err, context.Canceled) | ||
| }) | ||
| t.Run(c.name+"_OnePort", func(t *testing.T) { |
There was a problem hiding this comment.
This may also contribute to stability, one less test indentation. We probably need to start considering depth of tests and their interactions with each other or limiting depth to parent + subtest, not subsubtest.
kylecarbs
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that mix parallel/non-parallel parent tests and subtests will behave unexpectedly, this PR attempts to clean some of these up and does a little restructuring.
Ultimately, don't mix parallel/non-parallel and avoid too much nesting (sub-subtests).