Skip to content

fix: set default parameter value during update prompt #7292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Apr 26, 2023

fixes #7288

Feels hacky how I had to avoid using intialValues and also set the initialValue per component. However, it seemed like both were necessary as the form is initialized before the missing values are fetched. Before, when I submitted without changing the value, nothing happened.

@mtojek mtojek requested a review from BrunoQuaresma April 26, 2023 09:39
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 26, 2023
@BrunoQuaresma
Copy link
Collaborator

@bpmct I moved it to useEffect and fixed the lint. Can you please do some QA again just to check fi things are working as expected, please?

@BrunoQuaresma
Copy link
Collaborator

Closing this for now. I'm going to work on fix this in the root cause.

@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
@BrunoQuaresma BrunoQuaresma deleted the bpmct/7288 branch May 5, 2023 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default parameter value should not be a placeholder
2 participants