Skip to content

fix: set default parameter value during update prompt #7292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: set default parameter value during update prompt #7292

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af2784a
fix: set default parameter value during update prompt
bpmct Apr 26, 2023
222f5ee
fmt
bpmct Apr 26, 2023
7703333
Add logic inside of use effect
BrunoQuaresma Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@bpmct
bpmct committed Apr 26, 2023
commit 222f5eec72a6fc09c96f99d64af60591f5c0fc76
7 changes: 5 additions & 2 deletions site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const UpdateBuildParametersDialog: FC<
const styles = useStyles()
const form = useFormik({
initialValues: {
rich_parameter_values: []
rich_parameter_values: [],
},
validationSchema: Yup.object({
rich_parameter_values: useValidationSchemaForRichParameters(
Expand All @@ -49,7 +49,10 @@ export const UpdateBuildParametersDialog: FC<

// Set initial values for missing parameters, once fetched
if (missedParameters && form.values.rich_parameter_values.length === 0) {
form.setFieldValue("rich_parameter_values", selectInitialRichParametersValues(missedParameters))
form.setFieldValue(
"rich_parameter_values",
selectInitialRichParametersValues(missedParameters),
)
}

const getFieldHelpers = getFormHelpers(form)
Expand Down