refactor(site): Refactor error state #7313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw this doesn't fix #7300 it just refactors the error trace. |
|
It is a work around since a true fix is not possible and there is no prevision for that - we depend on vite but I'm almost sure it is kinda an hard problem - the build would have to keep the previous build files on the server. It is a workaround because after refresh the page, the index.html will be updated and reference the updated assets names. |
Kira-Pilot
reviewed
Apr 28, 2023
| error: Error | ||
| } | ||
| const fetchDynamicallyImportedModuleError = | ||
| "Failed to fetch dynamically imported module" as const |
There was a problem hiding this comment.
Why do we have to cast this as const?
There was a problem hiding this comment.
I don't remember, I think it was Co-pilot 🤔 I will remove it since does not influence anything
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Now:
GitHub issue prefilled:
Fix #7300