Skip to content

chore: Minor rbac memory optimization #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 3, 2023
Merged

chore: Minor rbac memory optimization #7391

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e86429
test: Add benchmark for static rbac roles
Emyrk May 3, 2023
a00b27b
static roles should only be allocated once
Emyrk May 3, 2023
7327595
Import order
Emyrk May 3, 2023
9225793
Add comments
Emyrk May 3, 2023
395be1c
Add comment on newbenchmark
Emyrk May 3, 2023
e8df351
Test was missing owner role
Emyrk May 3, 2023
bf32869
Add comment on benchmark about caching
Emyrk May 3, 2023
4c955ce
A unit test that modifies the ast value should not mess with the globals
Emyrk May 3, 2023
2bc9c7e
Cache subject AST values to avoid reallocating slices
Emyrk May 3, 2023
c90f7b7
add extra benchmark
Emyrk May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
A unit test that modifies the ast value should not mess with the globals
  • Loading branch information
@Emyrk
Emyrk committed May 3, 2023
commit 4c955ce19c7a83eaf448c55294b3b4201cd3e62d
13 changes: 12 additions & 1 deletion coderd/rbac/roles_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,19 @@ func BenchmarkRBACValueAllocation(b *testing.B) {
func TestRegoInputValue(t *testing.T) {
t.Parallel()

// Expand all roles and make sure we have a good copy.
// This is because these tests modify the roles, and we don't want to
// modify the original roles.
roles, err := RoleNames{RoleOrgMember(uuid.New()), RoleOrgAdmin(uuid.New()), RoleMember()}.Expand()
require.NoError(t, err, "failed to expand roles")
for i := range roles {
// If all cached values are nil, then the role will not use
// the shared cached value.
roles[i].cachedRegoValue = nil
}

actor := Subject{
Roles: RoleNames{RoleOrgMember(uuid.New()), RoleOrgAdmin(uuid.New()), RoleMember()},
Roles: Roles(roles),
ID: uuid.NewString(),
Scope: ScopeAll,
Groups: []string{uuid.NewString(), uuid.NewString(), uuid.NewString()},
Expand Down