Skip to content

chore: Minor rbac memory optimization #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 3, 2023
Merged

chore: Minor rbac memory optimization #7391

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e86429
test: Add benchmark for static rbac roles
Emyrk May 3, 2023
a00b27b
static roles should only be allocated once
Emyrk May 3, 2023
7327595
Import order
Emyrk May 3, 2023
9225793
Add comments
Emyrk May 3, 2023
395be1c
Add comment on newbenchmark
Emyrk May 3, 2023
e8df351
Test was missing owner role
Emyrk May 3, 2023
bf32869
Add comment on benchmark about caching
Emyrk May 3, 2023
4c955ce
A unit test that modifies the ast value should not mess with the globals
Emyrk May 3, 2023
2bc9c7e
Cache subject AST values to avoid reallocating slices
Emyrk May 3, 2023
c90f7b7
add extra benchmark
Emyrk May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment on benchmark about caching
  • Loading branch information
@Emyrk
Emyrk committed May 3, 2023
commit bf32869bef8ad66f6a4d1ec73e9bc389750deec7
3 changes: 3 additions & 0 deletions coderd/rbac/authz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ func BenchmarkRBACAuthorize(b *testing.B) {
uuid.MustParse("0632b012-49e0-4d70-a5b3-f4398f1dcd52"),
uuid.MustParse("70dbaa7a-ea9c-4f68-a781-97b08af8461d"),
)

// There is no caching that occurs because a fresh context is used for each
// call. And the context needs 'WithCacheCtx' to work.
authorizer := rbac.NewCachingAuthorizer(prometheus.NewRegistry())
// This benchmarks all the simple cases using just user permissions. Groups
// are added as noise, but do not do anything.
Expand Down