Skip to content

fix(site): Fix template icon field validation #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 4, 2023
Merged

fix(site): Fix template icon field validation #7394

merged 10 commits into from
May 4, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

I noticed two bugs so I made two fixes:

  • Validate max char on the icon field
  • Do not handle non 4xx errors as validation errors

FIx #7299

@BrunoQuaresma BrunoQuaresma requested a review from a team May 3, 2023 18:29
@BrunoQuaresma BrunoQuaresma self-assigned this May 3, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team May 3, 2023 18:29
@BrunoQuaresma BrunoQuaresma requested a review from Kira-Pilot May 4, 2023 13:51
Kira-Pilot
Kira-Pilot approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the util refactors (nice!) and the machines. Let me know if there's a particular way you'd like me to help test the general refactor; otherwise, looks good to me!

@BrunoQuaresma BrunoQuaresma merged commit 8909110 into main May 4, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-axios-error branch May 4, 2023 17:30
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

@rodrimaia rodrimaia Awaiting requested review from rodrimaia rodrimaia was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AxiosError returned when editing template in UI
2 participants
@BrunoQuaresma @Kira-Pilot