Skip to content

feat: added URL param name to allow setting workspace name #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2023
Merged

feat: added URL param name to allow setting workspace name #7528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a6683
feat: added URL param name to allow setting workspace name
MrPeacockNLB May 15, 2023
4419850
fix: format
MrPeacockNLB May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ const CreateWorkspacePage: FC = () => {
} = createWorkspaceState.context
const [searchParams] = useSearchParams()
const defaultParameterValues = getDefaultParameterValues(searchParams)
const name = getName(searchParams)

return (
<>
<Helmet>
<title>{pageTitle("Create Workspace")}</title>
</Helmet>
<CreateWorkspacePageView
name={name}
defaultParameterValues={defaultParameterValues}
loadingTemplates={createWorkspaceState.matches("gettingTemplates")}
loadingTemplateSchema={createWorkspaceState.matches(
Expand Down Expand Up @@ -96,6 +98,10 @@ const CreateWorkspacePage: FC = () => {
)
}

const getName = (urlSearchParams: URLSearchParams): string => {
return urlSearchParams.get("name") ?? ""
}

const getDefaultParameterValues = (
urlSearchParams: URLSearchParams,
): Record<string, string> => {
Expand Down
3 changes: 2 additions & 1 deletion site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export enum CreateWorkspaceErrors {
}

export interface CreateWorkspacePageViewProps {
name: string
loadingTemplates: boolean
loadingTemplateSchema: boolean
creatingWorkspace: boolean
Expand Down Expand Up @@ -92,7 +93,7 @@ export const CreateWorkspacePageView: FC<
const form: FormikContextType<TypesGen.CreateWorkspaceRequest> =
useFormik<TypesGen.CreateWorkspaceRequest>({
initialValues: {
name: "",
name: props.name,
template_id: props.selectedTemplate ? props.selectedTemplate.id : "",
rich_parameter_values: initialRichParameterValues,
},
Expand Down