feat: add workspaces banner for impending deletion #7538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await user.click(screen.getByTestId("dismiss-banner-btn")) | ||
|
|
||
| expect(banner).toBeEmptyDOMElement | ||
| }) |
There was a problem hiding this comment.
This looks like a rendering test - the test you want to check if something is rendered or not - do you think we should move this to the storybook? I feel this would be better to add it to jest.
There was a problem hiding this comment.
This test is checking flow - that the banner is visible until the user clicks 'Dismiss' and then it is hidden. However, adding a storybook is a great idea so I'll do that.
| clearLocal: (arg0: string) => void | ||
| } | ||
|
|
||
| export const useLocalStorage = (): UseLocalStorage => { |
BrunoQuaresma
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7365
Will add link to filter when filter exists.