feat: pubsub reports dropped messages #7660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
kylecarbs
approved these changes
May 24, 2023
Comment on lines
+35
to
+39
| // msgOrErr either contains a message or an error | ||
| type msgOrErr struct { | ||
| msg []byte | ||
| err error | ||
| } |
There was a problem hiding this comment.
Thoughts on moving the in-memory pubsub to its own package? I feel like I made a mistake bundling it inside database when I created it, and this seems like an opportunity to fix that.
There was a problem hiding this comment.
Happy to move it, but probably will open a separate PR. Where do you think it should go? subpackage of database?
We could move the interface & in-memory pubsub to coderd/pubsub?
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite for #7371 and #7295
When the pubsub loses database connection (e.g. due to network hiccup), subscribers might miss messages. This currently happens silently, which is bad for applications that use the pubsub as a dependable communication, rather than just a kick to query the database for updates.
This PR enhances the Pubsub to be able to report when messages might have been dropped, so that applications can take some action. In the case of streaming build logs, we'll probably just give up and propagate the error to the HTTP requestor. In the case of the tailnet coordinator, it means we need to resync state.