Skip to content

feat: pubsub reports dropped messages #7660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023
Merged

feat: pubsub reports dropped messages #7660

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a91aaa
Implementation; need linux tests
spikecurtis May 22, 2023
ede1415
Pubsub with errors tests and fixes
spikecurtis May 24, 2023
bbc8c4a
Deal with test goroutines
spikecurtis May 25, 2023
8e8d5c5
remove goleak -- lib/pq uses sleeps on notify :-(
spikecurtis May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deal with test goroutines 
Signed-off-by: Spike Curtis <spike@coder.com>
  • Loading branch information
@spikecurtis
spikecurtis committed May 25, 2023
commit bbc8c4af9d9b9738017e27dba066c9bfd062556a
5 changes: 3 additions & 2 deletions coderd/database/pubsub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ func TestPubsub_Disconnect(t *testing.T) {
defer pubsub.Close()
event := "test"

errors := make(chan error)
messages := make(chan string)
// buffer responses so that when the test completes, goroutines don't get blocked & leak
errors := make(chan error, database.PubsubBufferSize)
messages := make(chan string, database.PubsubBufferSize)
readOne := func() (m string, e error) {
t.Helper()
select {
Expand Down