fix: write to executor stats map while holding mutex #7731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
🌮 @mtojek for the report |
mtojek
reviewed
May 31, 2023
There was a problem hiding this comment.
I'm not quite sure if this is related:
=== Failed
=== FAIL: coderd/database TestPubsub_Disconnect (12.09s)
pubsub_test.go:125:
Error Trace: /home/runner/work/coder/coder/coderd/database/pubsub_test.go:125
Error: Received unexpected error:
could not start resource:
github.com/coder/coder/coderd/database/postgres.OpenContainerized
/home/runner/work/coder/coder/coderd/database/postgres/postgres.go:118
- API error (500): driver failed programming external connectivity on endpoint eager_bouman (bf988aa79d77ab9d95e89f294334975a89e9b70d955c9f8d8d6e96294644d893): Error starting userland proxy: listen tcp4 0.0.0.0:36475: bind: address already in use
github.com/ory/dockertest/v3.(*Pool).RunWithOptions
/home/runner/go/pkg/mod/github.com/ory/dockertest/v3@v3.9.1/dockertest.go:457
github.com/coder/coder/coderd/database/postgres.OpenContainerized
/home/runner/work/coder/coder/coderd/database/postgres/postgres.go:82
github.com/coder/coder/coderd/database_test.TestPubsub_Disconnect
/home/runner/work/coder/coder/coderd/database/pubsub_test.go:124
testing.tRunner
/opt/hostedtoolcache/go/1.20.3/x64/src/testing/testing.go:1576
runtime.goexit
/opt/hostedtoolcache/go/1.20.3/x64/src/runtime/asm_amd64.s:1598
Test: TestPubsub_Disconnect
Unrelated to this PR. Test was added in #7660 |
…-executor-concurrent-map-write
…-executor-concurrent-map-write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7710