Skip to content

fix: standardize on CODER_PG_CONNECTION_URL #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: standardize on CODER_PG_CONNECTION_URL #7781

merged 1 commit into from
Jun 1, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jun 1, 2023 •
edited
Loading

Fixes #7513.

Opted to just change it but if the breaking change is an issue we could make Env take a slice so we can accept the old var as well.

@code-asher code-asher marked this pull request as ready for review June 1, 2023 19:00
@code-asher code-asher requested a review from ammario June 1, 2023 19:01
ammario
ammario approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine because it's unlikely there's a lot of automation around this command.

@code-asher code-asher merged commit 9704945 into main Jun 1, 2023
@code-asher code-asher deleted the asher/standardize-pg-url-var branch June 1, 2023 23:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: coder: create-admin-user uses CODER_POSTGRES_URL instead of CODER_PG_CONNECTION_URL
2 participants
@code-asher @ammario