refactor: deprecate login_before_ready in favor of startup_script_behavior
#7837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
login_before_ready in favor of startup_script_behaviorlogin_before_ready in favor of startup_script_behavior
login_before_ready in favor of startup_script_behaviorlogin_before_ready in favor of startup_script_behavior
90a85ff to
7baef4d
Compare
mtojek
reviewed
Jun 5, 2023
| @@ -0,0 +1,8 @@ | |||
| ALTER TABLE workspace_agents ADD COLUMN login_before_ready boolean NOT NULL DEFAULT TRUE; | |||
There was a problem hiding this comment.
nit: Do we need begin & commit around this block?
There was a problem hiding this comment.
I suppose yes, fixed. I'm sometimes on the fence since we're not consistent about always using them. We should probably always enforce it, can't think of a reason not to.
coderd/database/migrations/000125_rename_login_before_ready_to_startup_script_behavior.up.sql
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in many ways just a cosmetic change, but quite a lot of code was touched to make it.
When
startup_script_behavioris set to a non-empty value, it is preferred, otherwise we attempt to read thelogin_before_readyvalue and translate it tostartup_script_behavior.Fixes #7758
Ref: #7757