chore: add warning log if misconfigured groups oidc #7874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not perfect, but if we find a 'groups' claim and it is not configured, put out a warning log to give some information
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect, but if we find a 'groups' claim and it is not
configured, put out a warning log to give some information
Also update the docs.
Rational
We can't just assume the default is
groupsif their scope is something likeMemberOf. This is because we want to determine if thegroupsis enabled purely by the config settings (before a user logs in). If the scope is something besidesgroups, we cannot know what claims it will return.So if the scope is
MemberOf, the deployment must also set--oidc-group-field=groups