feat(cli/ssh): implement wait options and deprecate no-wait #7894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffbdf29 to
2afc35c
Compare
2afc35c to
08da521
Compare
mafredri
commented
Jun 7, 2023
| @@ -92,6 +92,7 @@ func (r *RootCmd) portForward() *clibase.Cmd { | |||
| Fetch: func(ctx context.Context) (codersdk.WorkspaceAgent, error) { | |||
| return client.WorkspaceAgent(ctx, workspaceAgent.ID) | |||
| }, | |||
| Wait: false, | |||
There was a problem hiding this comment.
Review: Before change from NoWait -> Wait, these were bugs, added the explicit false here to signal intent.
08da521 to
2f223fe
Compare
johnstcn
reviewed
Jun 7, 2023
cli/ssh.go
Outdated
Comment on lines
53
to
54
| wait bool | ||
| noWait bool |
There was a problem hiding this comment.
Same as with #7893 (comment) - we could potentially (breaking-ly) refactor this to --wait=(always|never|auto)
Emyrk
approved these changes
Jun 7, 2023
johnstcn
reviewed
Jun 8, 2023
| Value: clibase.BoolOf(&noWait), | ||
| UseInstead: []clibase.Option{waitOption}, |
There was a problem hiding this comment.
It took me a hot second to see this as I was looking for Deprecated 🙃
johnstcn
approved these changes
Jun 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7768
Refs #7893