ci: improve Go caching #7954
ci: improve Go caching #7954
Conversation
| - name: Get cache dirs | ||
| shell: bash | ||
| run: | | ||
| set -x | ||
| echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_ENV | ||
| echo "GOCACHE=$(go env GOCACHE)" >> $GITHUB_ENV |
There was a problem hiding this comment.
This doesn't work on Windows runners
| ${{ env.GOMODCACHE }} | ||
| key: gomodcache-${{ runner.os }}-${{ hashFiles('**/go.sum') }}-${{ github.job }} | ||
| restore-keys: | | ||
| gomodcache-${{ runner.os }}-${{ hashFiles('**/go.sum') }}- |
There was a problem hiding this comment.
GOCACHE also has the github.job one listed
There was a problem hiding this comment.
I added a comment that may help this make more sense
| go-${{ runner.os }}-${{ github.job }}- | ||
| go-${{ runner.os }}- | ||
| go- | ||
| gocache-${{ runner.os }}-${{ github.job }}- |
There was a problem hiding this comment.
That was on purpose. It's how I've seen it done on a few docs. I guess it clearly symbolizes the end of a token.
| repo: gotestyourself/gotestsum | ||
| tag: v1.9.0 | ||
| shell: bash | ||
| run: go install gotest.tools/gotestsum@latest |
There was a problem hiding this comment.
Does not work on Windows AFAIK
| lint/go: | ||
| ./scripts/check_enterprise_imports.sh | ||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.53.2 |
There was a problem hiding this comment.
Can this be skipped if golangci-lint is in PATH?
There was a problem hiding this comment.
Why do it though? It runs almost instantly if already installed.
|
@deansheather the windows job seems to run fine? |
|
Force merging as folks are struggling with CI today. |
... Amongst various other minor improvements.