Skip to content

ci: improve Go caching #7954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 12, 2023
Merged

ci: improve Go caching #7954

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a26fd50
ci: cache Go only once
ammario Jun 10, 2023
0c2c580
Simplify
ammario Jun 10, 2023
d2909e8
Cache toolchain
ammario Jun 10, 2023
ece4e2a
Dump env
ammario Jun 10, 2023
2eeb2ae
Cache Go toolchain
ammario Jun 10, 2023
1004b9a
Use right cache?
ammario Jun 10, 2023
9f90b78
mhm
ammario Jun 10, 2023
1c36a07
Skip datadog on skip
ammario Jun 10, 2023
de837ce
no more dump env
ammario Jun 10, 2023
f8df5c9
Simplify lint
ammario Jun 10, 2023
901853b
fixup! Simplify lint
ammario Jun 10, 2023
06f7168
make fmt
ammario Jun 10, 2023
0b26856
improve lint
ammario Jun 10, 2023
2cb7884
fixup! improve lint
ammario Jun 10, 2023
fe09085
Reduce thrashing
ammario Jun 10, 2023
cc87000
fixup! Reduce thrashing
ammario Jun 10, 2023
2c7208a
fixup! Reduce thrashing
ammario Jun 10, 2023
9676000
fixup! Reduce thrashing
ammario Jun 10, 2023
0453d7e
fixup! Reduce thrashing
ammario Jun 10, 2023
9865c38
golangcilint only new files
ammario Jun 10, 2023
45aaa1e
cache golangci-lint
ammario Jun 10, 2023
82320d5
fixup! cache golangci-lint
ammario Jun 10, 2023
eb6a3ed
fixup! cache golangci-lint
ammario Jun 10, 2023
39c1fe5
Respond to review comments
ammario Jun 11, 2023
1ebc06e
Merge remote-tracking branch 'origin/main' into ci-dedup-cache
ammario Jun 12, 2023
6fcd675
supercharge fmt
ammario Jun 12, 2023
18a4011
Merge remote-tracking branch 'origin/main' into ci-dedup-cache
ammario Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Reduce thrashing
  • Loading branch information
@ammario
ammario committed Jun 10, 2023
commit cc8700040aca112a1bc5523411737a8da5ce89a8
6 changes: 2 additions & 4 deletions .github/actions/setup-go/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,10 @@ runs:
with:
path: |
${{ steps.get_cache_dirs.outputs.go-mod-cache }}}
key: gomodcache-${{ runner.os }}-${{ github.job }}-${{ hashFiles('**/go.sum') }}
key: gomodcache-${{ runner.os }}-${{ hashFiles('**/go.sum') }}-${{ github.job }}
restore-keys: |
gomodcache-${{ runner.os }}-${{ github.job }}-
gomodcache-${{ runner.os }}-${{ hashFiles('**/go.sum') }}-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOCACHE also has the github.job one listed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment that may help this make more sense

gomodcache-${{ runner.os }}-
gomodcache-

- name: Cache $GOCACHE
uses: buildjet/cache@v3
Expand All @@ -53,7 +52,6 @@ runs:
restore-keys: |
gocache-${{ runner.os }}-${{ github.job }}-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyphen at the end?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was on purpose. It's how I've seen it done on a few docs. I guess it clearly symbolizes the end of a token.

gocache-${{ runner.os }}-
gocache-

- name: Install gotestsum
shell: bash
Expand Down