Skip to content

feat: add disabling of default 'everyone' group access to template #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 14, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 12, 2023

Fixes #7658

Wording

Checkbox is disabled if you do not have the enterprise Template RBAC entitlement.

Screenshot from 2023-06-12 13-43-53

Screenshot from 2023-06-12 13-15-36

@Emyrk Emyrk marked this pull request as ready for review June 12, 2023 19:15
@Emyrk Emyrk requested a review from BrunoQuaresma June 12, 2023 19:15
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE looks good!

@Emyrk Emyrk requested a review from ammario June 13, 2023 14:48
@ammario ammario dismissed their stale review June 13, 2023 16:14

Should get someone else to review the Go. Thanks for changing the wording.

@Emyrk Emyrk requested a review from deansheather June 13, 2023 20:01
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go LGTM

Emyrk and others added 2 commits June 14, 2023 09:26
@Emyrk Emyrk merged commit 3619a3a into main Jun 14, 2023
@Emyrk Emyrk deleted the stevenmasley/disable_everyone_group branch June 14, 2023 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New templates purposely with no permissions (RBAC)
4 participants