Skip to content

test(cli): remove assertion for non-zero host CPU usage #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

johnstcn
Copy link
Member

Apparently host CPU usage is sometimes zero in an 100-millisecond interval.

Fixes #8091.

@johnstcn johnstcn requested review from mafredri and mtojek June 20, 2023 12:33
@johnstcn johnstcn self-assigned this Jun 20, 2023
@johnstcn johnstcn changed the title chore(cli): do not assert non-zero host cpu usage chore(cli): remove assertion for non-zero host CPU usage Jun 20, 2023
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this is what happens:

c1: {User:81h19m24.4s System:79h16m41.49s Idle:714h22m3.95s IOWait:66h52m52.75s IRQ:0s Nice:41m20.79s SoftIRQ:2h48m34.83s Steal:0s}
c2: {User:81h19m24.4s System:79h16m41.49s Idle:714h22m4.34s IOWait:66h52m52.75s IRQ:0s Nice:41m20.79s SoftIRQ:2h48m34.83s Steal:0s}
{
  "total": 4,
  "unit": "cores",
  "used": 0
}

@mafredri mafredri changed the title chore(cli): remove assertion for non-zero host CPU usage test(cli): remove assertion for non-zero host CPU usage Jun 20, 2023
@johnstcn johnstcn enabled auto-merge (squash) June 20, 2023 12:36
@johnstcn johnstcn merged commit eb0783f into main Jun 20, 2023
@johnstcn johnstcn deleted the cj/test-flake-coder-stat-host-cpu branch June 20, 2023 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: coder stat cpu returns used=0
2 participants