Skip to content

test(cli): remove assertion for non-zero host CPU usage #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023
Merged

test(cli): remove assertion for non-zero host CPU usage #8097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(cli): do not assert non-zero host cpu usage
  • Loading branch information
@johnstcn
johnstcn committed Jun 20, 2023
commit af901b7808633e6ebd6d6da4b360a28c4c77c31b
2 changes: 1 addition & 1 deletion cli/clistat/stat_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TestStatter(t *testing.T) {
t.Parallel()
cpu, err := s.HostCPU()
require.NoError(t, err)
assert.NotZero(t, cpu.Used)
// assert.NotZero(t, cpu.Used) // HostCPU can sometimes be zero.
assert.NotZero(t, cpu.Total)
assert.Equal(t, "cores", cpu.Unit)
})
Expand Down
2 changes: 1 addition & 1 deletion cli/stat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestStatCPUCmd(t *testing.T) {
s := buf.String()
tmp := clistat.Result{}
require.NoError(t, json.NewDecoder(strings.NewReader(s)).Decode(&tmp))
require.NotZero(t, tmp.Used)
// require.NotZero(t, tmp.Used) // Host CPU can sometimes be zero.
require.NotNil(t, tmp.Total)
require.NotZero(t, *tmp.Total)
require.Equal(t, "cores", tmp.Unit)
Expand Down