Skip to content

feat: add "display_order" column to coder_parameter to keep parameters sorted in UI #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 30, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Terraform tests ok
  • Loading branch information
mtojek committed Jun 30, 2023
commit 091888b740b706ba2b33c2a8e41aa84bc44154b4
28 changes: 28 additions & 0 deletions provisioner/terraform/resources_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,34 @@ func TestConvertResources(t *testing.T) {
DefaultValue: "ok",
}},
},
"rich-parameters-order": {
resources: []*proto.Resource{{
Name: "dev",
Type: "null_resource",
Agents: []*proto.Agent{{
Name: "dev",
OperatingSystem: "windows",
ShutdownScriptTimeoutSeconds: 300,
StartupScriptTimeoutSeconds: 300,
Architecture: "arm64",
Auth: &proto.Agent_Token{},
StartupScriptBehavior: "non-blocking",
ConnectionTimeoutSeconds: 120,
}},
}},
parameters: []*proto.RichParameter{{
Name: "Example",
Type: "string",
Required: true,
Order: 55,
}, {
Name: "Sample",
Type: "string",
Description: "blah blah",
DefaultValue: "ok",
Order: 99,
}},
},
"rich-parameters-validation": {
resources: []*proto.Resource{{
Name: "dev",
Expand Down
2 changes: 1 addition & 1 deletion provisioner/terraform/testdata/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail
cd "$(dirname "${BASH_SOURCE[0]}")"

for d in rich-parameters-validation/; do
for d in */; do
pushd "$d"
name=$(basename "$(pwd)")

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
terraform {
required_providers {
coder = {
source = "coder/coder"
version = "0.9.0"
}
}
}

data "coder_parameter" "sample" {
name = "Sample"
type = "string"
description = "blah blah"
default = "ok"
order = 99
}

data "coder_parameter" "example" {
name = "Example"
type = "string"
order = 55
}

resource "coder_agent" "dev" {
os = "windows"
arch = "arm64"
}

resource "null_resource" "dev" {
depends_on = [coder_agent.dev]
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading