-
Notifications
You must be signed in to change notification settings - Fork 889
chore: use dogfood-oss image in .devcontainer #8231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for submitting this, this will be huge! What else does this PR need to be ready for review? |
I need to test it on a VM or physical server. After that I will mark as ready for review. |
Hi, @bpmct I assume that not every user will be running a For getting docker in docker in
I can use some suggestions and feedback here. |
Context
This PR
.devcontainer
in coder/coder doesn't create a working dev environment. #7591Contributes to #7676
What does it do
devcontainer
feature to enable docker-in-docker.codercom/oss-dogfood:latest
image that we push on every change toDockerfile
coder/.github/workflows/dogfood.yaml
Line 45 in 59246e0
Testing
I have tested the proposed modification in
.devcontainer
.with
--privileged
)with following commands
make fmt
make lint
make test
./scripts/develop.sh
What we can do Next
Next, I am going to test a dogfood template using
coder/envbuilder
and.devcontainer
I guess we can also safely remove the docker installation from our dogfood
Dockerfile
Also, I would like to remove most of the packages we install in
Dockerfile
to be replaced with devcontainer features,e.g.,
This will make it modular and easy to maintain.