feat(site): increase max workspace lifetime TTL validation to 30 days #8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏼 Thanks for the contribution. The 7-day max validation is pretty arbitrary so I totally agree we should support longer times. We're currently reworking the behavior of the "max lifetime" to enforce stops/restarts every Since we're pretty far along with our refactor, I'm going to close this PR. Even if we merged it, I'm pretty sure it would be replaced before we did a release. |
|
Ah, here is the issue I am talking about #6917. If we don't end up shipping this soon, we'd be happy to reopen this and reconsider. We are pretty far along though. |
|
The new validation will allow for restarting on the weekend every 16 weeks. |
coadler
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing TTL limit of 7 days is fairly restrictive. This PR increases that to 30 days.