chore: use correct prettier version in ci #8321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flag for node setup to allow not installing all node_modules
277f0e9 to
c46e06f
Compare
mafredri
reviewed
Jul 5, 2023
| @@ -12,4 +17,4 @@ runs: | |||
| cache-dependency-path: "site/yarn.lock" | |||
| - name: Install node_modules | |||
| shell: bash | |||
| run: ./scripts/yarn_install.sh | |||
| run: ./scripts/yarn_install.sh ${{ inputs.yarn-install-flags }} | |||
There was a problem hiding this comment.
I think we need to make sure this input is part of the cache key, otherwise we'll be hopping back-n-forth between prettier-only and full install?
There was a problem hiding this comment.
Maybe that is why the cache is always taking 1minute.
I wonder if I even need to run install.sh
matifali
reviewed
Jul 5, 2023
.github/workflows/ci.yaml
Outdated
| @@ -183,7 +183,7 @@ jobs: | |||
| run: "make --output-sync -j -B gen" | |||
|
|
|||
| - name: Check for unstaged files | |||
| run: ./scripts/check_unstaged.sh | |||
| run: ./scripts/cgiheck_unstaged.sh | |||
matifali
reviewed
Jul 5, 2023
.github/workflows/ci.yaml
Outdated
| @@ -203,7 +203,11 @@ jobs: | |||
| go-version: 1.20.5 | |||
|
|
|||
| - name: Install prettier | |||
| run: npm install -g prettier | |||
| run: cd site && yarn --cache-folder=/tmp/yarn_pretty_cache install --prettier | |||
| with: | |||
There was a problem hiding this comment.
Yea, I am just going to stop trying to use the cache in this PR. Let's get things green on main then mess around with making it faster. I'm new to github actions
mafredri
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install globally is ignoring the yarn.lock with the right prettier version
The downside is installing prettier takes 1min each time 🤔
The caching thing
Let's get this green on
main, then figure out how to get the prettier install to be quicker.