Skip to content

chore: use correct prettier version in ci #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 5, 2023
Merged

chore: use correct prettier version in ci #8321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c46e06f
chore: fmt ci uses correct node setup
Emyrk Jul 5, 2023
bd122b5
fixup! chore: fmt ci uses correct node setup
Emyrk Jul 5, 2023
d940111
try with installing all deps
Emyrk Jul 5, 2023
57e6aa9
CI stuck?
Emyrk Jul 5, 2023
5631cfe
Remove with block
Emyrk Jul 5, 2023
fefd1ed
Revert to only install prettier
Emyrk Jul 5, 2023
acbeb7b
Implement a cache key for the prettier only cache
Emyrk Jul 5, 2023
dcf6c3c
Optional skip yarn_install
Emyrk Jul 5, 2023
13347dc
Install prettier locally
Emyrk Jul 5, 2023
81eabcd
Install prettier to global
Emyrk Jul 5, 2023
3003d21
use a local prettier
Emyrk Jul 5, 2023
41646cf
install prettier in site directory
Emyrk Jul 5, 2023
40fda6d
Do not skip install
Emyrk Jul 5, 2023
44069aa
Skip installing all deps
Emyrk Jul 5, 2023
52b6cb9
use the yarn cache
Emyrk Jul 5, 2023
c2b923d
Do not reload cache at all
Emyrk Jul 5, 2023
c1a2b77
Revert action file
Emyrk Jul 5, 2023
74e5b50
fixup! Revert action file
Emyrk Jul 5, 2023
ceea463
Save prettier cache
Emyrk Jul 5, 2023
6b7398b
remove cache, just get it working
Emyrk Jul 5, 2023
21829d6
Install correct prettier globally
Emyrk Jul 5, 2023
e627c15
format ci file
Emyrk Jul 5, 2023
97931f4
only install prettier
Emyrk Jul 5, 2023
ed417d0
Add comments
Emyrk Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: fmt ci uses correct node setup 
Add flag for node setup to allow not installing all node_modules
  • Loading branch information
@Emyrk
Emyrk committed Jul 5, 2023
commit c46e06f3fde9a37e8b2c066013a9414e39dc892d
7 changes: 6 additions & 1 deletion .github/actions/setup-node/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: "Setup Node"
description: |
Sets up the node environment for tests, builds, etc.
inputs:
yarn-install-flags:
description: "Flags to pass to yarn install"
required: false
default: ""
runs:
using: "composite"
steps:
Expand All @@ -12,4 +17,4 @@ runs:
cache-dependency-path: "site/yarn.lock"
- name: Install node_modules
shell: bash
run: ./scripts/yarn_install.sh
run: ./scripts/yarn_install.sh ${{ inputs.yarn-install-flags }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make sure this input is part of the cache key, otherwise we'll be hopping back-n-forth between prettier-only and full install?

Copy link
Member Author

@Emyrk Emyrk Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that is why the cache is always taking 1minute.

I wonder if I even need to run install.sh

9 changes: 4 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,19 +192,18 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- uses: buildjet/setup-node@v3
- uses: ./.github/actions/setup-node
with:
node-version: 16.16.0
# Only install prettier dep for this job
yarn-install-flags: "prettier"


- uses: buildjet/setup-go@v4
with:
# This doesn't need caching. It's super fast anyways!
cache: false
go-version: 1.20.5

- name: Install prettier
run: npm install -g prettier

- name: Install shfmt
run: go install mvdan.cc/sh/v3/cmd/shfmt@v3.5.0

Expand Down