chore(Makefile): add test-race target #8357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jul 7, 2023
| @@ -668,6 +668,11 @@ test-postgres-docker: | |||
| done | |||
| .PHONY: test-postgres-docker | |||
|
|
|||
| # Make sure to keep this in sync with test-go-race from .github/workflows/ci.yaml. | |||
| test-race: test-clean | |||
There was a problem hiding this comment.
Why do we wipe the test cache when we run via Makefile? Adding -count=1 should work the same and wouldn't trash the cache (e.g. for non-race tests).
There was a problem hiding this comment.
Should we update existing invocations to use -count=1 as well?
There was a problem hiding this comment.
Actually, I'll make a separate PR for that and we can debate in there.
There was a problem hiding this comment.
Good suggestion, I think that would be preferable 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Makefile target to run tests with the race detector enabled.