Skip to content

chore: enable exhaustruct linter #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2023
Merged

chore: enable exhaustruct linter #8403

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1123d06
chore: enable exhaustruct linter
johnstcn Jul 10, 2023
9c35bed
add exlusion rules
johnstcn Jul 11, 2023
c2c8ff2
move to allowlist instead
johnstcn Jul 11, 2023
bf2ab5e
exhaustruct httpmw package
johnstcn Jul 11, 2023
acc1a63
fixup! exhaustruct httpmw package
johnstcn Jul 11, 2023
6013986
make lint
johnstcn Jul 11, 2023
5270d5b
address PR comments
johnstcn Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add exlusion rules
  • Loading branch information
@johnstcn
johnstcn committed Jul 11, 2023
commit 9c35bedea478f1f9df757960c2ea898d1275e0b2
11 changes: 11 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
# Over time we should try tightening some of these.

linters-settings:
exhaustruct:
exclude:
- 'clibase\.Cmd'
- 'clibase\.Option'
- 'codersdk\.Response'
- 'codersdk\.\w+Request'
- 'http\.Client'
- "TypescriptType"
gocognit:
min-complexity: 46 # Min code complexity (def 30).

Expand Down Expand Up @@ -196,6 +204,9 @@ issues:
- errcheck
- forcetypeassert
- exhaustruct # This is unhelpful in tests.
- path: scripts/*
linters:
- exhaustruct

fix: true
max-issues-per-linter: 0
Expand Down