Skip to content

feat(cli): support ephemeral parameters #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 13, 2023
Merged

feat(cli): support ephemeral parameters #8415

merged 14 commits into from
Jul 13, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 11, 2023

Related: #6828

This PR extends CLI to support one-time parameters/ephemeral parameters/build options.

Screenshot 2023-07-11 at 16 35 29

The flag is available for:

  • coder update ...
  • coder create ...
  • coder start ...
  • coder restart ...

I can rename the flag name (--build-options ) to something more meaningful if anyone has an idea.


TODO:

  • update and create: skip ephemeral parameters unless the workspace user wants to set them (flag --build-options)
  • ... with unit tests
  • start: add --build-options flag to ask for ephemeral parameters
  • ... with unit tests
  • restart: add --build-options flag to ask for ephemeral parameters
  • ... with unit tests

@mtojek mtojek self-assigned this Jul 11, 2023
@mtojek mtojek requested review from mafredri, johnstcn and bpmct July 11, 2023 15:38
@mtojek mtojek marked this pull request as ready for review July 11, 2023 15:38
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature! 🤩

Noticed a few small nits but all in all this looks good. 👍🏻

@mtojek mtojek requested a review from mafredri July 13, 2023 10:21
@mtojek mtojek merged commit 5432c3f into main Jul 13, 2023
@mtojek mtojek deleted the 6828-cli branch July 13, 2023 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants