-
Notifications
You must be signed in to change notification settings - Fork 887
feat(cli): support ephemeral parameters #8415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jul 12, 2023
johnstcn
reviewed
Jul 12, 2023
johnstcn
approved these changes
Jul 12, 2023
mafredri
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature! 🤩
Noticed a few small nits but all in all this looks good. 👍🏻
bpmct
approved these changes
Jul 12, 2023
mafredri
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6828
This PR extends CLI to support one-time parameters/ephemeral parameters/build options.
The flag is available for:
coder update ...
coder create ...
coder start ...
coder restart ...
I can rename the flag name (
--build-options
) to something more meaningful if anyone has an idea.TODO:
update
andcreate
: skip ephemeral parameters unless the workspace user wants to set them (flag--build-options
)start
: add--build-options
flag to ask for ephemeral parametersrestart
: add--build-options
flag to ask for ephemeral parameters