feat: add custom coder bin path for ProxyCommand #8425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Jul 12, 2023
mafredri
approved these changes
Jul 13, 2023
cli/configssh.go
Outdated
| @@ -501,6 +508,14 @@ func (r *RootCmd) configSSH() *clibase.Cmd { | |||
| Description: "Specifies the path to an SSH config.", | |||
| Value: clibase.StringOf(&sshConfigFile), | |||
| }, | |||
| { | |||
| Flag: "coder-cli-path", | |||
There was a problem hiding this comment.
How about just using binary-path (without prefix)? I feel like cli terminology isn't something we expose the users to in association with the coder command, and may cause a disconnect.
There was a problem hiding this comment.
One thing I was trying to make clear in the flag was this was the coder binary path, not anything else like the ssh binary.
Is coder-binary-path too long?
There was a problem hiding this comment.
Nah, not too long IMO, your reasoning makes sense 👍🏻
|
smart to force it to be absolute 👍. As for who will use it. It is definitely an edge case that I am only adding because someone specifically requested it and it doesn't seem like too much to add. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8217