Skip to content

feat(site): display version message #8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 13, 2023
Merged

feat(site): display version message #8435

merged 14 commits into from
Jul 13, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jul 11, 2023 •
edited by matifali
Loading

Display version message on:

  • Outdated tooltip
  • Template version header page
  • Add a message field when creating a new version in the UI
Screen Shot 2023-07-11 at 16 24 25 Screen Shot 2023-07-11 at 16 29 03

Close #8342
closes: #3775

@BrunoQuaresma BrunoQuaresma requested a review from mafredri July 11, 2023 19:29
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 11, 2023
mafredri
mafredri reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thought about handling one more case with existing and empty message (see comments).

@matifali
Copy link
Member

Also, consider
#8456

@BrunoQuaresma
Copy link
Collaborator Author

Close #3775

@BrunoQuaresma BrunoQuaresma requested a review from mafredri July 12, 2023 13:32
mafredri
mafredri approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed an issue in the last commits if you want to take a look, but other than that, this looks good!

One last question, were we planning on showing message as column in this table too?

image

@BrunoQuaresma
Copy link
Collaborator Author

@mafredri I think for this design, it would be too much but I will think more about that after this PR 🤔 we probably can make a better use of a different design for this.

@BrunoQuaresma BrunoQuaresma merged commit b833861 into main Jul 13, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/add-version-message branch July 13, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add into the UI the version message Add a changelog/message on template push
3 participants
@BrunoQuaresma @matifali @mafredri