Skip to content

feat(cli): add --create flag to templates push #8454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2023
Merged

feat(cli): add --create flag to templates push #8454

merged 6 commits into from
Jul 13, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 12, 2023 •
edited
Loading

Fixes: #6851

This PR allows to automatically create a template while using the coder templates push command. To simplify workflow, it uses default flags for all TTLs and DisableEveryoneGroupAccess.

@mtojek mtojek requested a review from johnstcn July 13, 2023 08:06
@mtojek mtojek marked this pull request as ready for review July 13, 2023 08:06
johnstcn
johnstcn approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine for now, but I foresee future feature requests for parity with coder templates create.

@mtojek mtojek merged commit 3727e02 into main Jul 13, 2023
@mtojek mtojek deleted the 6851-template-push-create branch July 13, 2023 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push, but create if does not exist: coder templates push --create
2 participants
@mtojek @johnstcn