Skip to content

feat(cli): add --create flag to templates push #8454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 13, 2023
Merged

feat(cli): add --create flag to templates push #8454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d05f331
Flag: create
mtojek Jul 12, 2023
ceebc75
Create the template if it does not exist
mtojek Jul 12, 2023
9401f38
Unit test
mtojek Jul 12, 2023
836b9d2
fix
mtojek Jul 12, 2023
9fd4c97
fix
mtojek Jul 12, 2023
c503d15
tests
mtojek Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tests
  • Loading branch information
@mtojek
mtojek committed Jul 13, 2023
commit c503d156860777eb1a67624b645b17128311324a
5 changes: 2 additions & 3 deletions cli/templatepush.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,10 @@ func (r *RootCmd) templatePush() *clibase.Cmd {
var createTemplate bool
template, err := client.TemplateByName(inv.Context(), organization.ID, name)
if err != nil {
if create {
createTemplate = true
} else {
if !create {
return err
}
createTemplate = true
}

err = uploadFlags.checkForLockfile(inv)
Expand Down
5 changes: 4 additions & 1 deletion cli/templatepush_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,10 +644,13 @@ func TestTemplatePush(t *testing.T) {
write string
}{
{match: "Upload", write: "yes"},
{match: "template has been created"},
}
for _, m := range matches {
pty.ExpectMatch(m.match)
pty.WriteLine(m.write)
if m.write != "" {
pty.WriteLine(m.write)
}
}

waiter.RequireSuccess()
Expand Down