Skip to content

test: Fix ProjectVersionLogs returning error when using DB #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

kylecarbs
Copy link
Member

This didn't actually effect the test value, since we're just looking for
logs. It did produce spam in the logs though, and could be interpreted
as a failure.

This didn't actually effect the test value, since we're just looking for
logs. It did produce spam in the logs though, and could be interpreted
as a failure.
@kylecarbs kylecarbs requested a review from coadler April 4, 2022 14:43
@kylecarbs kylecarbs self-assigned this Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #852 (33094ab) into main (8e56830) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   65.84%   65.69%   -0.15%     
==========================================
  Files         202      202              
  Lines       13209    13209              
  Branches       87       87              
==========================================
- Hits         8697     8678      -19     
- Misses       3622     3637      +15     
- Partials      890      894       +4     
Flag Coverage Δ
unittest-go- 65.05% <ø> (-0.22%) ⬇️
unittest-go-macos-latest 52.55% <ø> (+0.11%) ⬆️
unittest-go-ubuntu-latest 54.97% <ø> (-0.01%) ⬇️
unittest-go-windows-2022 51.75% <ø> (-0.02%) ⬇️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/provisionerdaemons.go 58.51% <0.00%> (-2.03%) ⬇️
peer/conn.go 78.93% <0.00%> (-1.78%) ⬇️
provisionerd/provisionerd.go 79.14% <0.00%> (-1.18%) ⬇️
provisioner/echo/serve.go 59.20% <0.00%> (+2.40%) ⬆️
coderd/workspaceresources.go 60.56% <0.00%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e56830...33094ab. Read the comment docs.

@kylecarbs kylecarbs merged commit f2a2126 into main Apr 4, 2022
@kylecarbs kylecarbs deleted the fixprojectversionlogs branch April 4, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants