feat(helm): add commandArgs for custom entrypoint #8567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer we just provided a e.g.: coder:
command: /bin/sh
commandArgs:
- '-c'
- 'echo "hello world" && coder server'Default to |
|
thanks @deansheather - how should we specify |
There was a problem hiding this comment.
Needs a test in the tests dir, you can add a test by adding it to the list in the _test.go file and adding a corresponding values file with the same name in the testdata dir. Then run make --always-make update-golden-files to save the generated chart for your test. Double check the outputted file before committing to make sure it looks as you would expect
bpmct
reviewed
Jul 18, 2023
deansheather
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds the
commandArgsvalue to support passing custom arguments into the Coder container.one of our large customers needs this feature to pass in a custom PostgreSQL connection URL environment variable. they are looking to reference the database password from a volume mounted on the container. the below example meets this requirement: