test(agent): fix TestAgent_Metadata/Once flake
#8613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a race condition between checking `lastCollectedAts` and spawning the singleflight that could cause a metadata to execute multiple times, even if specified to run once. This moves the `lastCollectedAts` check to inside the singleflight to actually ensure the validity of the checks.
TestAgent_Metadata/Once flakeTestAgent_Metadata/Once flake
TestAgent_Metadata/Once flakeTestAgent_Metadata/Once flake
|
You can merge off my review if you want to, but I didn't meticulously vet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race condition between checking
lastCollectedAtsand spawning the singleflight that could cause a metadata to execute multiple times, even if specified to run once. This moves thelastCollectedAtscheck to inside the singleflight to actually ensure the validity of the checks.Also fixes an issue where the context timeout could be 0.
Latest failure