Skip to content

Add sidebar and panel #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2022
Merged

Add sidebar and panel #866

merged 2 commits into from
Apr 5, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Added:

  • Sidebar component
  • Panel component, because I noticed the Sidebar was only used inside of a Panel
  • Moved overrides and props from the old v1 theme. I also removed some styles that required more code that was not used right now.

Closes #659

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 4, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 4, 2022 19:51
@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #866 (be8eea0) into main (7833c24) will decrease coverage by 0.22%.
The diff coverage is 22.44%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   65.81%   65.58%   -0.23%     
==========================================
  Files         202      210       +8     
  Lines       13209    13358     +149     
  Branches       87       96       +9     
==========================================
+ Hits         8693     8761      +68     
- Misses       3626     3700      +74     
- Partials      890      897       +7
Flag Coverage Δ
unittest-go- 65.19% <ø> (-0.04%) ⬇️
unittest-go-macos-latest 52.60% <ø> (+0.28%) ⬆️
unittest-go-ubuntu-latest 55.06% <ø> (+0.03%) ⬆️
unittest-go-windows-2022 51.91% <ø> (+0.18%) ⬆️
unittest-js 60.31% <22.44%> (-2.33%) ⬇️
Impacted Files Coverage Δ
site/src/components/Panel/index.tsx 0.00% <0.00%> (ø)
site/src/components/Sidebar/index.tsx 0.00% <0.00%> (ø)
site/src/util/combine-classes.ts 0.00% <0.00%> (ø)
site/src/theme/overrides.ts 100.00% <100.00%> (ø)
site/src/theme/props.ts 100.00% <100.00%> (ø)
site/src/theme/theme.ts 100.00% <100.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
peer/conn.go 77.15% <0.00%> (-2.54%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833c24...be8eea0. Read the comment docs.

presleyp
presleyp reviewed Apr 4, 2022
View reviewed changes
@BrunoQuaresma BrunoQuaresma requested a review from presleyp April 5, 2022 14:24
@BrunoQuaresma BrunoQuaresma merged commit abddd64 into main Apr 5, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/sidebar branch April 5, 2022 17:01
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@presleyp presleyp presleyp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Tab Sidebar Component
3 participants
@BrunoQuaresma @presleyp @misskniss