Skip to content

test: improve pr deployments #8720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 25, 2023
Merged

test: improve pr deployments #8720

merged 11 commits into from
Jul 25, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 25, 2023 •
edited
Loading

This prepares for when #8714 is available.

  1. Deploys PRs on pr${{ PR_NUMBER }}.test.cdr.dev
  2. Port forwarding support with CODER_WILDCARD_ACCESS_URL
  3. Installs coder-logstream-kube
  4. Each PR is deployed in a separate namespace.
  5. Supports Kubernetes template

TODO:

  1. Github OAuth
  2. Create the first user, template, and workspace automatically.
  3. Support the Docker template by mounting the docker host and make it public chmod 666 /var/run/docker.sock (not safe)

@matifali matifali changed the title test: imrpve pr deployments test: improve pr deployments Jul 25, 2023
@matifali matifali marked this pull request as ready for review July 25, 2023 20:52
@matifali matifali requested a review from bpmct July 25, 2023 20:53
cdr-bot[bot]
cdr-bot bot approved these changes Jul 25, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali merged commit 86d4c4f into main Jul 25, 2023
@matifali matifali deleted the matifai/prdeploymnets branch July 25, 2023 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matifali