Skip to content

chore(scripts): use fake semver when using sapling #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore(scripts): use fake semver when using sapling #8747

merged 1 commit into from
Jul 26, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Jul 26, 2023

chore(scripts): use fake semver when using sapling

The fact that the Sapling commit didn't conform to semver
broke the agent handshake with coderd.


Stack created with Sapling. Best reviewed with ReviewStack.

@ammario ammario added the hotfix label Jul 26, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

The fact that the Sapling commit didn't conform to semver
broke the agent handshake with coderd.
@ammario ammario merged commit f28bac1 into main Jul 26, 2023
@ammario ammario deleted the pr8747 branch July 26, 2023 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant