Skip to content

ci: further improve pr deployments #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 27, 2023
Merged

ci: further improve pr deployments #8764

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d77492c
grammer and typo
matifali Jul 27, 2023
6194883
Merge branch 'main' into improve-cleanup
matifali Jul 27, 2023
2b5d1f5
only deploy PRs
matifali Jul 27, 2023
24dc7c2
add dry run flag
matifali Jul 27, 2023
7e19879
add -s shortcut
matifali Jul 27, 2023
4c0d5ad
make it better
matifali Jul 27, 2023
d6eb49b
fmt
matifali Jul 27, 2023
deb70d8
unquote
matifali Jul 27, 2023
6289417
lint
matifali Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unquote
  • Loading branch information
@matifali
matifali committed Jul 27, 2023
commit deb70d8f5e8a64e1591695a2331b731e5c5eb468
4 changes: 2 additions & 2 deletions scripts/deploy-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ if $dryRun; then
echo "branchName: ${branchName}"
echo "prNumber: ${prNumber}"
echo "skipBuild: ${skipBuild}"
echo "gh workflow run pr-deploy.yaml --ref "${branchName}" -f pr_number="${prNumber}" -f skip_build="${skipBuild}""
echo "gh workflow run pr-deploy.yaml --ref ${branchName} -f pr_number=${prNumber} -f skip_build=${skipBuild}"
exit 0
fi

gh workflow run pr-deploy.yaml --ref "${branchName}" -f pr_number="${prNumber}" -f skip_build="${skipBuild}"
gh workflow run pr-deploy.yaml --ref ${branchName} -f pr_number=${prNumber} -f skip_build=${skipBuild}