chore: upgrade nodejs version to 18.x #8768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Jul 27, 2023
| @@ -13,7 +13,7 @@ runs: | |||
| - name: Setup Node | |||
| uses: buildjet/setup-node@v3 | |||
| with: | |||
| node-version: 16.20.1 | |||
| node-version: 18.17.0 | |||
There was a problem hiding this comment.
Suggested change
| node-version: 18.17.0 | |
| node-version: 18.x |
As we are installing the latest 18.x release in Dockerfile should we also do this in ci?
@kylecarbs for a 2nd thought.
There was a problem hiding this comment.
Why not? The docker file is for the workspace and the CI should use the same version as well.
| @@ -190,6 +190,7 @@ RUN LAZYGIT_VERSION=$(curl -s "https://api.github.com/repos/jesseduffield/lazygi | |||
| # Install frontend utilities | |||
| RUN apt-get update && \ | |||
| # Node.js (from nodesource) and Yarn (from yarnpkg) | |||
| curl -fsSL https://deb.nodesource.com/setup_18.x | sudo -E bash - &&\ | |||
There was a problem hiding this comment.
Here we are installing the latest 18.x release.
kylecarbs
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8386