Skip to content

feat: Add user menu #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 7, 2022
Merged

feat: Add user menu #887

merged 8 commits into from
Apr 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #743

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 6, 2022 16:01
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 6, 2022
BrunoQuaresma
BrunoQuaresma commented Apr 6, 2022
View reviewed changes
BrunoQuaresma
BrunoQuaresma commented Apr 6, 2022
View reviewed changes
BrunoQuaresma
BrunoQuaresma commented Apr 6, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #887 (d17a808) into main (23f9891) will decrease coverage by 0.55%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   66.54%   65.99%   -0.56%     
==========================================
  Files         126      218      +92     
  Lines       12854    13849     +995     
  Branches        0      103     +103     
==========================================
+ Hits         8554     9139     +585     
- Misses       3401     3789     +388     
- Partials      899      921      +22
Flag Coverage Δ
unittest-go- 65.87% <ø> (+0.13%) ⬆️
unittest-go-macos-latest 52.93% <ø> (+0.01%) ⬆️
unittest-go-ubuntu-latest 55.32% <ø> (+0.01%) ⬆️
unittest-go-windows-2022 52.28% <ø> (+0.03%) ⬆️
unittest-js 59.09% <46.66%> (?)
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/pages/preferences/index.tsx 0.00% <0.00%> (ø)
site/src/components/Icons/DocsIcon.tsx 100.00% <100.00%> (ø)
site/src/components/Navbar/UserDropdown.tsx 96.29% <100.00%> (ø)
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
peerbroker/proxy.go 58.13% <0.00%> (-3.49%) ⬇️
provisionerd/provisionerd.go 80.17% <0.00%> (-1.03%) ⬇️
coderd/provisionerdaemons.go 62.05% <0.00%> (-1.02%) ⬇️
site/src/components/Table/index.tsx 0.00% <0.00%> (ø)
site/src/forms/CreateWorkspaceForm.tsx 86.66% <0.00%> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f9891...d17a808. Read the comment docs.

greyscaled
greyscaled reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we storybook the user dropdown?

@BrunoQuaresma
Copy link
Collaborator Author

@vapurrmaid added storybook and unit tests

@BrunoQuaresma BrunoQuaresma requested a review from greyscaled April 6, 2022 17:50
greyscaled
greyscaled suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge latest main into this branch so that we get the Chromatic workflow to run

presleyp
presleyp suggested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test! Same comment on this one - can you pull out the labels into a Language constant and then, you can also use that constant in your tests to make them less brittle in what they target. Feel free not to in any cases where you think we should test that the language is actually what we expect it to be.

@BrunoQuaresma
Copy link
Collaborator Author

Good suggestion @presleyp, it is added!

presleyp
presleyp reviewed Apr 7, 2022
View reviewed changes
presleyp
presleyp approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a tiny thing but basically good to go!

greyscaled
greyscaled approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's safe to ignore the chromatic error here - it's because in #910 the secret token was deleted. You can either merge latest main, and CI will rerun, or just merge.

@BrunoQuaresma BrunoQuaresma merged commit 90388a3 into main Apr 7, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/usermenu branch April 7, 2022 16:00
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@greyscaled greyscaled greyscaled approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

User Menu - Beta
4 participants
@BrunoQuaresma @presleyp @greyscaled @misskniss