Skip to content

docs: add missing last_seen_before and last_seen_after search parameter #9096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Aug 15, 2023

We added this #8139 but haven't documented it. Thoughts on also adding a helper @Emyrk?

image

Also curious for your thoughts on ways we can add other search filters without missing docs. I don't think it has to be as complex as a linter rule or autogenerating these. Perhaps a comment could help?

@bpmct bpmct requested a review from Emyrk August 15, 2023 00:37
@Emyrk
Copy link
Member

Emyrk commented Aug 15, 2023

I have no issue with it. Seems like a design thing as a calandar picker might be helpful

@bpmct bpmct added the hotfix label Aug 16, 2023
@bpmct bpmct enabled auto-merge (squash) August 16, 2023 23:20
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@bpmct bpmct merged commit fa8e103 into main Aug 16, 2023
@bpmct bpmct deleted the lastused_docs branch August 16, 2023 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
@Emyrk
Copy link
Member

Emyrk commented Aug 17, 2023

Oh this was a PR 🤦. I thought it was an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants